[Reliability] Add failsafe decoding for Bool when string/data is received #9849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #9839
Description
This PR increases the app's resilience when
ProductorProductVariationfields that expect aBoolreceive aStringinstead:backordersAllowedonSaleIt uses failsafe decoding to handle those alternative types, and adds to the unit tests for parsing alternative types. (These are known decoding errors that users have experienced for these fields.)
Testing instructions
We don't know the exact plugins that can cause this behavior, but you can test using a tool like Charles Proxy or Proxyman to intercept and modify the response:
/wc/v3/productsendpoint.backorders_allowedfield returns a string representing a boolean value (e.g."backorders_allowed": "1").on_salefield returns a string representing a boolean value (e.g."on_sale": "0").You can repeat the same steps with the variations list for a variable product, modifying the same fields in the response for a variation.
RELEASE-NOTES.txtif necessary.